Skip to content

fix(breaking-change): ACNA-3718 - remove @openwhisk/wskdebug from the default action generator #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
purplecabbage merged 1 commit into from
Apr 16, 2025
Merged

fix(breaking-change): ACNA-3718 - remove @openwhisk/wskdebug from the default action generator #77

purplecabbage merged 1 commit into from
Apr 16, 2025

Conversation

@shazron
Copy link
Member

@shazron shazron commented Apr 7, 2025 •
edited
Loading

We are using the app-dev plugin for local debugging now.
See also: adobe/aio-cli-plugin-app#854

This is a BREAKING CHANGE so it requires a major version update.

Unfortunately, it has 28 dependents - so those dependents will need to update their version of common lib IF they use the addAction functionality. Ideally we update everything.

Start with https://github.com/adobe/generator-aio-app/blob/420490da23ac758cdcf5c5556781ef963850263a/package.json#L51C1-L61C43

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title fix: remove @openwhisk/wskdebug from the default action generator fix(breaking-change): remove @openwhisk/wskdebug from the default action generator Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8079a8f) to head (cabe8d9).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          361       362    +1     
  Branches        60        61    +1     
=========================================
+ Hits           361       362    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Apr 7, 2025
Closed
Merged
@shazron shazron changed the title fix(breaking-change): remove @openwhisk/wskdebug from the default action generator fix(breaking-change): ACNA-3718 - remove @openwhisk/wskdebug from the default action generator Apr 7, 2025
@shazron
Copy link
Member Author

shazron commented Apr 15, 2025 •
edited
Loading

10 separate PRs will be filed for the repos below, dependent on this PR being merged and released as a major version v3.

These libs need to update their @adobe/generator-app-common-lib dep to the new major version v3, and subsequently update to major versions themselves:

    "@adobe/generator-add-action-analytics": "^1", -> 2
    "@adobe/generator-add-action-asset-compute": "^2" -> 3,
    "@adobe/generator-add-action-campaign-standard": "^1", -> 2
    "@adobe/generator-add-action-customer-profile": "^1", -> 2
    "@adobe/generator-add-action-generic": "^1", -> 2
    "@adobe/generator-add-action-target": "^1", -> 2

These two require the libs above to updated to new major versions:   

"@adobe/generator-app-asset-compute": "^2", -> 3
"@adobe/generator-app-excshell": "^1", -> 2

Lastly:

  1. update @adobe/generator-aio-app with the right major versions above, release a major version
  2. update @adobe/aio-cli-plugin-app with the new major version of @adobe/generator-aio-app

@purplecabbage purplecabbage merged commit 2d5244d into main Apr 16, 2025
10 checks passed
@purplecabbage purplecabbage deleted the remove-wskdebug branch April 16, 2025 17:39
@purplecabbage purplecabbage mentioned this pull request Apr 16, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moritzraho moritzraho moritzraho approved these changes

@amulyakashyap09 amulyakashyap09 amulyakashyap09 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shazron @moritzraho @amulyakashyap09 @purplecabbage